Pm publishpackage cherrypick tests #14654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f5d5563 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 12:12:19 2023 +0000 dispose methods null checks - trying to prevent null exceptions in case resources have been cleared before dispose event has been called commit e43ad53 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 11:05:20 2023 +0000 remove begin invoke from mainFrame_Navigated - this was done to try and fix a failing test but it should not be needed commit 42bf04c Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 21:04:19 2023 +0000 null check to mainFrame_Navigated - added a null check commit 9dde030 Merge: a77a11a 3f765b5 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 18:07:39 2023 +0000 Merge branch 'pm-publishpackage-cherrypick-resources' into pm-publishpackage-cherrypick-mypackage commit a77a11a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:47:17 2023 +0000 main changes - this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow commit 3f765b5 Merge: 95d502a 36fb8d3 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-cherrypick-resources commit 95d502a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:02 2023 +0000 resource cherry-pick - picked up all resource changes
…-cherrypick-tests
|
@dnenov There are 4 failures here |
…-cherrypick-tests
- it seems that the new .dll files introduce are not being copied or used in test environment - the tests were reworked to discount the dll files
|
Ready to be merged @reddyashish |
|
self-serve CI passed https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1305/ |
reddyashish
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The third final part of cherry-picks from #14631. This PR is based on #14645.
The current PR contains all the tests that were added for the work around the MyPackage module in the package manager.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@QilongTang
FYIs