Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start running serialization view tests again #14590

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Nov 10, 2023

Purpose

Nunit3 has different behavior when it comes to catching assertions than nunit 2 - they still mark the test a failure, so we ignore the results of a few different nodes whose behavior actually changes depending on where the graph is executed from.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner mjkkirschner requested a review from sm6srw November 10, 2023 01:26
@mjkkirschner mjkkirschner added this to the 3.0 milestone Nov 10, 2023
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Should we create a follow-up for the remaining ones?

@mjkkirschner
Copy link
Member Author

sorry @sm6srw did I miss some failures?

@sm6srw
Copy link
Contributor

sm6srw commented Nov 10, 2023

@mjkkirschner No, it was late last night. You are good.

@mjkkirschner
Copy link
Member Author

adds 30 minutes to the tests, but it passes everywhere - if we want to run less of these for faster test runs in the future I'm okay with that.

@mjkkirschner mjkkirschner merged commit b90e84d into DynamoDS:master Nov 10, 2023
17 checks passed
@mjkkirschner mjkkirschner deleted the serial branch November 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants