Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dyn-6201 test followup #14572

Merged
merged 14 commits into from
Nov 6, 2023
Merged

dyn-6201 test followup #14572

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f21d3cd
fix first test
mjkkirschner Oct 31, 2023
26c6e27
work on docs browser
mjkkirschner Nov 1, 2023
7bc8727
fix test and broken docs image loading from pkgs
mjkkirschner Nov 1, 2023
dd080a2
add another test, fix dyn loading
mjkkirschner Nov 1, 2023
7504a03
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into pkgtest
mjkkirschner Nov 2, 2023
7ddb5b3
fix asm version
mjkkirschner Nov 3, 2023
b76d815
replace binary with renamed one
mjkkirschner Nov 3, 2023
5d528cb
try to fix tests
mjkkirschner Nov 3, 2023
ba7240c
Merge branch 'master' into pkgtest
mjkkirschner Nov 3, 2023
cbca65f
Merge branch 'master' into pkgtest
QilongTang Nov 3, 2023
ec946b6
rename package with node docs assembly and namespace
mjkkirschner Nov 3, 2023
e74a4f4
review comments
mjkkirschner Nov 6, 2023
e498b45
conflict
mjkkirschner Nov 6, 2023
8abc4fe
merge undid my changes
mjkkirschner Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/DynamoCoreWpfTests/ViewExtensions/DocumentationBrowserViewExtensionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ public void CanCreatePackageNodeDocumentationAndLoadImages()

// Assert
Assert.IsTrue(!string.IsNullOrEmpty(browserView.VirtualFolderPath));
//TODO this is false because package image loading is now broken.
Assert.IsTrue(Directory.Exists(browserView.VirtualFolderPath));
//Check that the virtual folder will be created in the Package/doc folder so images will be loaded correctly
Assert.IsTrue(browserView.VirtualFolderPath.Contains(packageDocPath));
Expand Down Expand Up @@ -761,7 +760,7 @@ public void AddGraphInSpecificLocationToWorkspace()
docsViewModel.InsertGraph();
}
//Validates that we have 5 nodes the CurrentWorkspace (after the graph was added)
//Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Nodes.Count(), 5);
Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Nodes.Count(), 5);
}

[Test]
Expand Down Expand Up @@ -831,7 +830,7 @@ public void Validate_GetGraphLinkFromPackage()
Assert.IsTrue(!string.IsNullOrEmpty(graphPathValue));

//check that the path contains "packageWithDocumentation"
Assert.That(graphPathValue.Contains("PackageWithNodeDocumentation\\doc"));
Assert.That(graphPathValue.Contains(Path.Combine("PackageWithNodeDocumentation","doc",dynFileName)));
}

#region Helpers
Expand Down
Loading