Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check file size workflow #14551

Merged

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Nov 1, 2023

Purpose

  • write list of changed files to a text file.
    Looping through the string of filenames failed when file name contained special characters. After writing the list of changed files to a text file, we can read the file for filenames and surround the filename in double quotes before processing.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@avidit avidit force-pushed the feature/update-check-file-size-workflow branch from 86f92b4 to 9b946b0 Compare November 1, 2023 15:23
- write list of changed files to a file
@avidit avidit force-pushed the feature/update-check-file-size-workflow branch from 9b946b0 to 02899fc Compare November 1, 2023 15:30
@avidit avidit merged commit 98d3097 into DynamoDS:master Nov 1, 2023
17 checks passed
@avidit avidit deleted the feature/update-check-file-size-workflow branch November 1, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants