Cleanup net48 code #14489
Merged
Cleanup net48 code #14489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
approved these changes
Oct 17, 2023
| </Reference> | ||
| <Reference Include="WindowsBase" /> | ||
| <Reference Include="Microsoft.Practices.Prism"> | ||
| <HintPath>..\..\extern\prism\Microsoft.Practices.Prism.dll</HintPath> |
There was a problem hiding this comment.
so can we remove this binary now?
There was a problem hiding this comment.
I think so. Will do
|
good stuff. |
There was a problem hiding this comment.
Don't we want to wait until we remove DynamoCrypto?
| @@ -9,1362 +9,11 @@ | |||
| namespace Dynamo.Tests | |||
| { | |||
|
|
|||
| #if NET6_0_OR_GREATER | |||
| [TestFixture, Apartment(ApartmentState.MTA)] | |||
| public class ExcelTests | |||
| { | |||
| } | |||
There was a problem hiding this comment.
Can you remind me why we didn't have any excel tests for net6?
There was a problem hiding this comment.
#14041 (comment)
Looks like we simply forgot to do it after all projects were migrated
I will enable them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the net48 preprocessor directives in the source code