Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm bring back toast notifications #14474

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Oct 9, 2023

Purpose

A small PR part of the package manager work. Reinstates the toast notification prompts informing the user of the status of a package download. This functionality existed before, and is just being brought back into the new UI unchanged but for a few minor design tweaks as per the recent design guides.

Visual changes

toast notifications

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • when downloading package, use will get notified with a short status message in the bottom-hand side of the UI
  • this message existed before, it is now brought back in the UI
  • slight visual update to the toast notification as per Figma

Reviewers

@QilongTang

FYIs

@Amoursol

- when downloading package, use will get notified with a short status message in the bottom-hand side of the UI
- this message existed before, it is now brought back in the UI
- slight visual update to the toast notification as per Figma
@QilongTang QilongTang added this to the 3.0 milestone Oct 10, 2023
@QilongTang QilongTang merged commit 9fb6e65 into DynamoDS:master Oct 10, 2023
18 checks passed
@QilongTang
Copy link
Contributor

Thank you for bringing back these code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants