Skip to content

Commit

Permalink
Stop localizing github issue title (#14584)
Browse files Browse the repository at this point in the history
  • Loading branch information
avidit authored Nov 8, 2023
1 parent 8b3d879 commit 83fdc96
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
3 changes: 0 additions & 3 deletions src/DynamoCoreWpf/Properties/Resources.en-US.resx
Original file line number Diff line number Diff line change
Expand Up @@ -2252,9 +2252,6 @@ Uninstall the following packages: {0}?</value>
<data name="DynamoViewSettingMenuShowDataReportingDialogTooltip" xml:space="preserve">
<value>Display the dialog for user to pick agreement on data collecting.</value>
</data>
<data name="CrashPromptGithubNewIssueTitle" xml:space="preserve">
<value>Crash report from Dynamo {0}</value>
</data>
<assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
<data name="psDynamoMesh" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\ViewModels\Watch3D\compiledShaders\psDynamoMesh;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
Expand Down
3 changes: 0 additions & 3 deletions src/DynamoCoreWpf/Properties/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -2462,9 +2462,6 @@ Want to publish a different package?</value>
<value>Custom Nodes will be placed in the Add-Ons section of the library.</value>
<comment>Note regarding Custom Node library location</comment>
</data>
<data name="CrashPromptGithubNewIssueTitle" xml:space="preserve">
<value>Crash report from Dynamo {0}</value>
</data>
<data name="PackageSearchViewSearchTextBoxSyncing" xml:space="preserve">
<value>Please wait...</value>
</data>
Expand Down
3 changes: 1 addition & 2 deletions src/DynamoCoreWpf/Utilities/CrashUtilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ internal static string GithubNewIssueUrlFromCrashContent(object crashContent)
{
var baseUri = new UriBuilder(Configurations.GitHubBugReportingLink);

// provide fallback values for text content in case Resources or Assembly calls fail
var issueTitle = Properties.Resources.CrashPromptGithubNewIssueTitle ?? "Crash report from Dynamo {0}";
var issueTitle = "Crash report from Dynamo {0}";
var dynamoVersion = AssemblyHelper.GetDynamoVersion().ToString() ?? "2.1.0+";

// append the title and body to the URL as query parameters
Expand Down

0 comments on commit 83fdc96

Please sign in to comment.