Best-Effort Tracing #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpholt
commented
Dec 4, 2023
| (implicit F: MonadCancelThrow[F], | ||
| L1: Local[F, Span[F]], | ||
| L2: Logger[F]): F[A] = | ||
| Resource.applyFull { (poll: Poll[F]) => |
There was a problem hiding this comment.
This is the main bit; the rest of this is tests and preserving binary compatibility with previous releases.
j-gens
reviewed
Dec 4, 2023
| @@ -42,16 +43,21 @@ class TraceResourceLifecycleOps[F[_], A](val resource: Resource[F, A]) extends A | |||
| * and finalization phases of the passed `Resource[F, A]` are traced in | |||
| * separate root spans. | |||
| * | |||
| * Unfortunately on Scala 2.12, because of the way extention methods are | |||
| * encoded, it is not possible to add an implicit Logger[F] to warng if | |||
There was a problem hiding this comment.
nit small typo here - warng instead of warn
gorskilauren
previously approved these changes
Dec 4, 2023
bpholt
force-pushed
the
best-effort-tracing
branch
from
6050a42 to
985a00c
Compare
j-gens
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tracing is unavailable for some reason, we don't want the overall program to fail; rather, we just want to ignore the tracing failure and continue on. This does so, emitting a log message when the failure occurs.