Fix Gradle and add some new Item mappings #3
Conversation
|
added a few more |
not perfect, especially on field names will need some updating
|
OK i think i made the changes |
| @@ -0,0 +1,14 @@ | |||
| CLASS net/minecraft/class_865 net/minecraft/item/map/MapState | |||
There was a problem hiding this comment.
Seems like an odd name for this. Perhaps MapData?
I ran out of time wil do more im moraning
| FIELD field_1347 air I | ||
| FIELD field_1348 touchingWater Z | ||
| FIELD field_1512 firstUpdate Z | ||
| FIELD field_1691 skinURL Ljava/lang/String; |
There was a problem hiding this comment.
Would prefer Url but is just kinda personal convention; and I don't think we ever decided on a convention for here.
| FIELD field_2746 renderDistanceMultiplier D | ||
| FIELD field_2903 isFireImmune Z | ||
| FIELD field_3004 attacked Z | ||
| FIELD field_3103 capeURL Ljava/lang/String; |
| FIELD field_2704 iDToEntity Ljava/util/Map; | ||
| FIELD field_2705 entityToID Ljava/util/Map; |
There was a problem hiding this comment.
| FIELD field_2704 iDToEntity Ljava/util/Map; | |
| FIELD field_2705 entityToID Ljava/util/Map; | |
| FIELD field_2704 IdToEntity Ljava/util/Map; | |
| FIELD field_2705 entityToId Ljava/util/Map; |
| METHOD method_1401 create (Ljava/lang/String;Lnet/minecraft/class_14;)Lnet/minecraft/class_1; | ||
| METHOD method_1927 create (ILnet/minecraft/class_14;)Lnet/minecraft/class_1; |
There was a problem hiding this comment.
Probably could be helpful to have a clear semantic in method name but it's hard to tell without context
There was a problem hiding this comment.
This file shouldn't exist as mappings/net/minecraft/item/map/MapCoordinates.mapping takes its place.
There was a problem hiding this comment.
This file shouldn't exist as mappings/net/minecraft/item/map/MapState.mapping takes its place.
Actually, it is unclear which one should be the primary one.
There was a problem hiding this comment.
Conflicted with mappings/net/minecraft/item/MapState.mapping
Hola, the gradle requested a nonexistant folder in the nonexistant master branch of the old intermediaries repo, i have fixed this replacing it with the better main branch and the actual folder name and also brought it down 1.7.3 and added many new item mappings