Back button & warning when asked to "Login Anonymously" or "Login" #736
Conversation
Issue No : Dun-sin#250 Updated the Docker Link that Redirects to Docker rather than MongoDB
* refactor: place sockets in seperate folder and remove console messages * fix: unreachable files * refactor: return err rather than using console.log * refactor: return err rather than using console.log
feat: add markdown support
* feat: add markdown support * feat: add package
* fix: login && connecting user * feat: implement logout with kinde * chore: ran npm i for build
* add: kinde for auth * Update README.md
* Update doc_issue.yml * Update bug.yml (Dun-sin#278) * Update features.yml (Dun-sin#279) * Update other.yml * Update other.yml
* Added quote reply feature * Made some changes in chat.jsx for quote reply feature --------- Co-authored-by: Dunsin <[email protected]>
Co-authored-by: Dunsin <[email protected]>
…un-sin#714) Co-authored-by: Dunsin <[email protected]>
Co-authored-by: Ayush Majumder <[email protected]> Co-authored-by: Dunsin <[email protected]>
…-sin#728) Co-authored-by: _sameer <[email protected]>
...Depending on the time assigned to an issue
…in#729) Co-authored-by: _sameer <[email protected]> Co-authored-by: Dunsin <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
rimshaejaz
changed the title
|
@rimshaejaz pull request is rejected, reason 👉🏾is here👈🏾 Thanks for wanting to contribute, I hope you continue to do so properly. |
**My PR attempts to fix issue #720 **
There is no back button when the user is asked to choose "Login". Instead, the user has to go back through the browser back button. Having a back button on the "Login" page would stylistically make the page look nicer. Also, having an "Are you sure you want to login anonymously?” message would be nice in case the user accidentally clicks this option.