feat: move reconnect banner to a new component #692
Conversation
|
@LuseBiswas is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- package-lock.json
|
@Dun-sin I checked all the things and I found out that there is restirictions in a Max-Character Limit in One Line. So I break the Line into several parts to encounter that error. I know its sound silly but can you please provide to me. Actually I am new in Open Source Contribution. SO thats why. |
|
@LuseBiswas pls stop creating new prs and just edit and fix your current PR, google it if you don't know how secondly, you didn't fill the PR properly and the compliance error is still there(look at what i said in the last PR you just closed) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@LuseBiswas here's the vercel link |
|
@Dun-sin Thankyou for guiding me in detail. I had done all the changes as you said. Let me know if any other changes I need to do. |
|
@LuseBiswas also fill the PR template properly, you can edit it, check the 3 dots by the side of it |
|
Hey @Dun-sin I just made all the changes:- But there is an extra empty commit there named "[Merge resolved: Your commit message here]" it is done by me intentionally, actually I was facing problem to reset the last commit so I had to force the commit. Kindly look at that while merging it. |
|
@Dun-sin if any changes I need to make then let me know. I'll make that. Because of your support I learnt so much new things.🙂 |
| <Anonymous | ||
| onChatClosed={startNewSearch} | ||
| /> | ||
| //Changes made here with moviing reconnector to another component. |
There was a problem hiding this comment.
don't think you ran prettier for this file, do you have prettier installed on your VSCode(it should automatically do this on each save)
@LuseBiswas don't worry about the commit, that's normal, i will handle that when i merge this. you still need to provide the screenrecording in your PR. It can be a screenshot like in this PR -> #683 or a screenrecoding like this PR -> #680 |
|
Hey @Dun-sin its been a day I am trying to get that reconnect banner option on the web app. I tried to being offline and decreasing my internet speed through Network tab from inspection. But I am unable to get that. It is not like this problem I am facing on my local website. Its even in your hosted website too. I think you should check it out. 
|
|
Thanks, will look into it |
|
@LuseBiswas create a new PR with the right branch, which is anything other than main and remove package.json |
|
@Dun-sin I am so sorry...but actually I was little busy with my academics....I will make it ASAP. |
Fixes Issue
**My PR closes #691 **
👨💻 Changes proposed(What did you do ?)
I just made another component i.e. ReconnectBanner.jsx in Components 📁 of Client and And applied it in BuddyMatcher.jsx by pasing props.
✔️ Check List (Check all the applicable boxes)
Note to reviewers
📷 Screenshots