-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:Moved menu toggle into it's own component #687
Conversation
Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
@Priyanshu-2005 Please fix this error, if you don't know how, try this:
Lastly read the issue description and fix your PR accordingly
|
// const MenuToggle = (props, ref) => { | ||
// return ( | ||
// <IconButton | ||
// {...props} | ||
// ref={ref} | ||
// icon={<Icon as={BiDotsVerticalRounded} />} | ||
// appearance="subtle" | ||
// circle | ||
// /> | ||
// ); | ||
// }; | ||
<MenuToggle/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you know react and if you don't feel free to stop working on this PR
Fixes Issue #660
My PR closes #issue_number_here
π¨βπ» Changes proposed(What did you do ?)
Moved menu toggle into its own component by creating a component named menu toggle then imported MenuToggle into Anonymous.jsx file and used it there.
<MenuToggle/>
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots