-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Function (Funda) for #170 #220
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bhailang-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request introduces 6 alerts when merging 74b5630 into fc11311 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 774d9c1 into fc11311 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging fc93884 into fc11311 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 0ffb32e into fc11311 - view on LGTM.com new alerts:
|
Great work! will check. |
Does it support closures ? Not working in preview. |
you have a typo "apan" the keyword is "apna" |
This pull request introduces 2 alerts when merging 3336243 into 0181ca4 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 3dc5b92 into 0181ca4 - view on LGTM.com new alerts:
|
Great work @thecodacus. I will look into this. I was thinking to have duck typing in the functions. But this will also work |
Shouldnt we have it outside hi bhai? Like other languages? Hi bhai is the execution entry point |
@ankitchouhan1020 @aniketsingh0104 or @ristri - could one of you review and approve the PR to be merged with the develop branch? This is such a cool and important feature. Eager to see this spreading against after playing around with this a bit in the netlify preview playground. |
To be reviewed this week. |
packages/parser/src/components/parser/statement/expression/callableExpression.ts
Outdated
Show resolved
Hide resolved
packages/parser/src/components/parser/statement/functionStatement.ts
Outdated
Show resolved
Hide resolved
packages/parser/src/components/parser/statement/functionStatement.ts
Outdated
Show resolved
Hide resolved
packages/parser/src/components/parser/statement/functionStatement.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical:
I see test cases are missing from this change specially from Parser. We won't review any PRs which do not contain proper test cases. Please write proper test cases covering positive and negative scenarios for both PARSER and INTERPRETER.
packages/parser/src/components/parser/statement/expression/callableExpression.ts
Show resolved
Hide resolved
Complete Review would be only possible after the test cases are included. |
Thanks for the review till now, I will make the changes and add test cases |
This pull request introduces 2 alerts when merging 567b961 into de68714 - view on LGTM.com new alerts:
|
test cases added |
took me a while to get the time and make the changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes implemented
This pull request introduces 2 alerts when merging a2b0d83 into de68714 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Can this be merged, looks very useful bhai |
This PR closes issue #154 and Based on #170, this will be the first stage to make it more like a real programming language.
added Functional Programming features,
you can now create
funda
(functions) to make your code modularized, and not repeat yourselfexample
output