Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑️ I deleted a plugin that had no content. #990

Merged
merged 4 commits into from
Sep 8, 2024
Merged

🗑️ I deleted a plugin that had no content. #990

merged 4 commits into from
Sep 8, 2024
+2 −0

Conversation

Corvus400
Copy link
Contributor

Issue

  • None.

Overview (Required)

  • While dealing with other tasks, I found that there were plugins that were not being executed, so I deleted them.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2024 04:57 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 7, 2024 05:09
takahirom
takahirom approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I sometimes use this plugin to debug the recomposition. So how about commenting out the apply("land.sungbin.composeinvestigator") and just removing the plugin from the plugins {} block?

@Corvus400
Copy link
Contributor Author

I'll go back to the draft for today and deal with it again tomorrow. 🙏

@Corvus400 Corvus400 marked this pull request as draft September 7, 2024 10:33
@Corvus400 Corvus400 requested a review from takahirom September 8, 2024 02:25
@Corvus400 Corvus400 marked this pull request as ready for review September 8, 2024 02:25
@Corvus400
Copy link
Contributor Author

@takahirom
I have modified it so that only comments are added.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 02:28 Inactive
takahirom
takahirom approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙏

@takahirom takahirom merged commit 127207d into DroidKaigi:main Sep 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corvus400 @takahirom