Refactor TimetableItemTag API to use consistent colors #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detekt check failed. Please run |
mannodermaus
force-pushed
the
fix/tag-outline-colors
branch
from
8565512 to
992cff3
Compare
mannodermaus
force-pushed
the
fix/tag-outline-colors
branch
from
992cff3 to
a985e5b
Compare
There are now two variants of this component. The first requires color+icon and is used for the colored 'room' tags. Any other usage in the app uses the same grayish color and no icon, so expose that as a second variant
mannodermaus
force-pushed
the
fix/tag-outline-colors
branch
from
a985e5b to
cdecf9b
Compare
takahirom
reviewed
Sep 8, 2024
| tagText = label, | ||
| tagColor = MaterialTheme.colorScheme.outline, | ||
| ) | ||
| TimetableItemTag(tagText = label) |
takahirom
approved these changes
Sep 8, 2024
![KaigiAppTest[KaigiApp - when app is starting - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/app-android/build/outputs/roborazzi/KaigiAppTest%5BKaigiApp%20-%20when%20app%20is%20starting%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![FavoritesScreenTest[FavoritesScreen - when server is operational - setup many favorite sessions - click first session bookmark - it should display favorite session without first session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/favorites/build/outputs/roborazzi/FavoritesScreenTest%5BFavoritesScreen%20-%20when%20server%20is%20operational%20-%20setup%20many%20favorite%20sessions%20-%20click%20first%20session%20bookmark%20-%20it%20should%20display%20favorite%20session%20without%20first%20session%5D_compare.png){kind=link}
![FavoritesScreenTest[FavoritesScreen - when device is tablet - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/favorites/build/outputs/roborazzi/FavoritesScreenTest%5BFavoritesScreen%20-%20when%20device%20is%20tablet%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![FavoritesScreenTest[FavoritesScreen - when server is operational - setup single favorite session - it should display favorite session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/favorites/build/outputs/roborazzi/FavoritesScreenTest%5BFavoritesScreen%20-%20when%20server%20is%20operational%20-%20setup%20single%20favorite%20session%20-%20it%20should%20display%20favorite%20session%5D_compare.png){kind=link}
![FavoritesScreenTest[FavoritesScreen - when server is operational - setup many favorite sessions - scroll favorites - it should first session is not displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/favorites/build/outputs/roborazzi/FavoritesScreenTest%5BFavoritesScreen%20-%20when%20server%20is%20operational%20-%20setup%20many%20favorite%20sessions%20-%20scroll%20favorites%20-%20it%20should%20first%20session%20is%20not%20displayed%5D_compare.png){kind=link}
![FavoritesScreenTest[FavoritesScreen - when server is operational - setup many favorite sessions - it should display favorite session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/favorites/build/outputs/roborazzi/FavoritesScreenTest%5BFavoritesScreen%20-%20when%20server%20is%20operational%20-%20setup%20many%20favorite%20sessions%20-%20it%20should%20display%20favorite%20session%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when font scale is small - it should show small font session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20font%20scale%20is%20small%20-%20it%20should%20show%20small%20font%20session%20detail%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when device is tablet - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20device%20is%20tablet%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest.runTest[TimetableItemDetailScreen - when server is operational - when launch - it should be appropriately accessible]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest.runTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20be%20appropriately%20accessible%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category App Architecture en - it should selected category App Architecture en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20App%20Architecture%20en%20-%20it%20should%20selected%20category%20App%20Architecture%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter day chip click - when click conference day 2 - it should selected day 2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20day%20chip%20click%20-%20when%20click%20conference%20day%202%20-%20it%20should%20selected%20day%202%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-12 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-12%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category Other en - it should selected category Other en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20Other%20en%20-%20it%20should%20selected%20category%20Other%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language MIXED - it should selected language MIXED]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20MIXED%20-%20it%20should%20selected%20language%20MIXED%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language ENGLISH - it should selected language ENGLISH]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20ENGLISH%20-%20it%20should%20selected%20language%20ENGLISH%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - it should show session detail title]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20show%20session%20detail%20title%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - input search word to TextField - it should show search word and filtered items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20input%20search%20word%20to%20TextField%20-%20it%20should%20show%20search%20word%20and%20filtered%20items%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category Jetpack Compose en - it should selected category Jetpack Compose en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20Jetpack%20Compose%20en%20-%20it%20should%20selected%20category%20Jetpack%20Compose%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter day chip click - when click conference day 1 - it should selected day 1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20day%20chip%20click%20-%20when%20click%20conference%20day%201%20-%20it%20should%20selected%20day%201%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click first session bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20first%20session%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - click bookmark again - it should show unBookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20click%20bookmark%20again%20-%20it%20should%20show%20unBookmarked%20session%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when font scale is large - it should show title in a single line]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20font%20scale%20is%20large%20-%20it%20should%20show%20title%20in%20a%20single%20line%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when device is tablet - input search word to TextField - it should show search word and filtered items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20device%20is%20tablet%20-%20input%20search%20word%20to%20TextField%20-%20it%20should%20show%20search%20word%20and%20filtered%20items%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - scroll timetable - it should first session is not displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20scroll%20timetable%20-%20it%20should%20first%20session%20is%20not%20displayed%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-11 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-11%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-13 - it should show timetable items for ConferenceDay2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-13%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay2%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click conference day2 tab - it should change displayed day]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20conference%20day2%20tab%20-%20it%20should%20change%20displayed%20day%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language JAPANESE - it should selected language JAPANESE]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/tag-outline-colors/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20JAPANESE%20-%20it%20should%20selected%20language%20JAPANESE%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Screenshot (Optional if screenshot test is present or unrelated to UI)
Note the subtle change for the gray tags.