Index #1040
Index #1040
Conversation
| return ( | ||
| f"Not enough funds to create new orders after {final_note} evaluation: " | ||
| f"{self.exchange_manager.exchange_name} exchange minimal order " | ||
| f"volume has not been reached." | ||
| ) |
There was a problem hiding this comment.
That's the reason why symbol is None?
There was a problem hiding this comment.
in index trading, we don't send a given symbol to buy, we tell the consumer to "rebalance the index" and the consumer will create orders accordingly (it's not symbol related).
Currently:
- producer decides if a rebalance should happen
- consumer executes the rebalance
There was a problem hiding this comment.
(it's not symbol related).
That's my point, I don't understand why we trigger this error here when symbol is None. I don't think it's a good idea to trigger this error due to the expected caller
There was a problem hiding this comment.
This function's goal is to log an error, if it's called it's that the error already occured and we want inform the user that an error occured. This symbol condition allows to create the error without given symbols, which is a case that can now happen
| assert consumer.get_holdings_ratio("ETH", include_assets_in_open_orders=True) \ | ||
| == decimal.Decimal('0.01819090909090909090909090909') |
There was a problem hiding this comment.
I don't understand why this value doesn't change due to order_3 addition
There was a problem hiding this comment.
we are selling XRP for ETH in order3 making more ETH available when it will be filled
There was a problem hiding this comment.
So why the ETH ratio is the same as without order_3 ?
There was a problem hiding this comment.
it's not the same, before it was 0.01818181818181818181818181818 and after it's 0.01819090909090909090909090909
There was a problem hiding this comment.
Oooh right, my bad. It saw the same number 😄
requires Drakkar-Software/OctoBot-Commons#423