[ProfileData] add exchange_type #447
Merged
+62
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeDSM
force-pushed
the
exchange_data
branch
2 times, most recently
from
ebec703 to
55f6731
Compare
GuillaumeDSM
force-pushed
the
exchange_data
branch
from
55f6731 to
b8b5330
Compare
GuillaumeDSM
changed the title
GuillaumeDSM
commented
Nov 30, 2024
| @@ -35,15 +35,18 @@ class ProfileDetailsData(octobot_commons.dataclasses.FlexibleDataclass): | |||
| class CryptoCurrencyData(octobot_commons.dataclasses.FlexibleDataclass): | |||
| trading_pairs: list[str] | |||
| name: typing.Union[str, None] = None | |||
| leverage: typing.Union[float, None] = None | |||
There was a problem hiding this comment.
this is to set leverage for a specific pair
| exchange_id: typing.Union[str, None] = None | ||
| proxy_id: typing.Union[str, None] = None | ||
| default_leverage: typing.Union[float, None] = None |
There was a problem hiding this comment.
this is to set a default leverage for a bot
There was a problem hiding this comment.
Should we create a FutureExchangeData and put default leverage in it? As, if I remember well, margin trading also has a "leverage" value
GuillaumeDSM
force-pushed
the
exchange_data
branch
from
b8b5330 to
644a559
Compare
Herklos
approved these changes
Dec 1, 2024
GuillaumeDSM
force-pushed
the
exchange_data
branch
from
644a559 to
55c0997
Compare
GuillaumeDSM
force-pushed
the
exchange_data
branch
from
55c0997 to
876e6ab
Compare
Herklos
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.