[ClockSync] add support for linux root users #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
reviewed
Feb 5, 2023
octobot_commons/os_clock_sync.py
Outdated
| @@ -39,11 +39,13 @@ def _get_sync_cmd(self): | |||
| platform = os_util.get_os() | |||
| bot_type = os_util.get_octobot_type() | |||
| if bot_type == commons_enums.OctoBotTypes.DOCKER.value: | |||
| raise NotImplementedError(bot_type) | |||
| return "service ntp stop && ntpd -gq && service ntp start" | |||
There was a problem hiding this comment.
There is no ntp service in the current octobot docker image
There was a problem hiding this comment.
I added it to the dockerfile as well see PR in octobot -> [Docker] add ntp to docker version
There was a problem hiding this comment.
I don't think we should add ntp service in docker based on this thread: https://stackoverflow.com/questions/24551592/how-to-make-sure-dockers-time-syncs-with-that-of-the-host
There was a problem hiding this comment.
Oh yeah crap, I removed the docker part, now only the linux root fix is included
techfreaque
force-pushed
the
ntp_debian_docker
branch
from
4830814 to
0a32c83
Compare
techfreaque
force-pushed
the
ntp_debian_docker
branch
from
0a32c83 to
82d5fab
Compare
techfreaque
force-pushed
the
ntp_debian_docker
branch
from
82d5fab to
730ff92
Compare
techfreaque
changed the title
Herklos
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: removed the docker changes as its not working