Format numbers used in views #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote a new function (formatNumber) that removes floating point errors and adds thousands separators to a number, and applied this function to the results of most numeric variables sent to StatusBar.ts
|
Just checking in to say that I've been using this updated version for the past week and am happy with the results. Numbers just look correct for the context! |
|
Can we merge this already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on @DrYoshiyahu formatting to always present formatted numbers, and in one case preserving the
numberwhere it is used for calculations (but not shown to user). Addresses lukeleppan#103 and lukeleppan#111This is not the best organization/naming, but it compiles and works as expected.
Screenshot showing Total Pages (
tp) and Words per Day (wpd) that are properly rounded.Screenshot showing Current Pages (
p) and Total Pages (ppd) that are properly rounded.