Remove dependencies for CUDA::nvtx3 and fix gpu.sh for cholmod #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphBLAS 8.3.0: rmm_wrap, static lib. ParU: misc cleanup. root-cmakelists workflow. UMFPACK: stale include files. Use same version for SPQR, and its GPU libraries
GraphBLAS: CUDA fixes, demo output
|
Looks good to me. 👍 Could you please change the target branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the following change to the project
It's quite embarrassing to admit that with cmake 3.22, the build system cannot find CUDA::nvtx3, as I test build with CUDA on WSL. Howerver, I find that the current project is unnecessary to link to the library. So I think remove the dependency for CUDA::nvtx3 is the best solution. Otherwise, we need to check whether CMake version is 3.25+. If it's above 3.25, then we can link to CUDA::nvtx3, elsewise we can link to CUDA::nvToolsExt.
Besides ,the script in CHOLMOD/Demo should be changed to cholmod_dl_demo instead of cholmod_l_demo. As the demo has specified the precision.