Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metadata Capitalization #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Metadata Capitalization #8

wants to merge 1 commit into from

Conversation

dirtycajunrice
Copy link

Ref - Ryan :)

BenVlodgi
BenVlodgi approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@BenVlodgi BenVlodgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change brings the naming of Metadata in line with the engine usage: Metadata Specifiers.

@DoubleDeez
Copy link
Owner

Some areas got refactored while I was implementing support for Structs, once conflicts are resolved I'm good to merge this

@rlabrecque
Copy link

s/MDMetaData/MDMetadata/ everywhere afterwards too 👀 ?

@DoubleDeez
Copy link
Owner

s/MDMetaData/MDMetadata/ everywhere afterwards too 👀 ?

Just gotta get the redirectors right. I believe renaming files would cause issues with perforce (and probably other things) though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenVlodgi BenVlodgi BenVlodgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dirtycajunrice @DoubleDeez @rlabrecque @BenVlodgi