Merge pull request #76 from Daoud-mohamed/Accumulate-payment-methods

Fix Hook Returns to Improve Payment Module Compatibility
DoliCloud · Dec 5, 2024 · 080d37d · 080d37d
2 parents 16ef1b1 + 37afef2
commit 080d37d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/htdocs/helloasso/class/actions_helloasso.class.php b/htdocs/helloasso/class/actions_helloasso.class.php
@@ -403,7 +403,7 @@ public function doAddButton($parameters, &$object, &$action, $hookmanager)
 
 		if (!$error) {
 			$this->resprints = $resprints;
-			return 1; // or return 1 to replace standard code
+			return 0; // or return 1 to replace standard code
 		} else {
 			$this->errors[] = $error;
 			return -1;
@@ -741,12 +741,11 @@ public function getBankAccountPaymentMethod($parameters, &$object, &$action, $ho
 			}
 		}
 
-		if (!$error) {
+		if (!$error && $bankaccountid > 0) {
 			$this->results["bankaccountid"] = $bankaccountid;
 			return 1;
 		} else {
-			$this->errors[] = $langs->trans("BankAccountNotFound");
-			return -1;
+			return 0;
 		}
 	}
 

diff --git a/htdocs/stancerdolicloud/class/actions_stancerdolicloud.class.php b/htdocs/stancerdolicloud/class/actions_stancerdolicloud.class.php
@@ -411,7 +411,7 @@ public function doAddButton($parameters, &$object, &$action, $hookmanager)
 
 		if (!$error) {
 			$this->resprints = $resprints;
-			return 1; // or return 1 to replace standard code
+			return 0; // or return 1 to replace standard code
 		} else {
 			$this->errors[] = $error;
 			return -1;
@@ -731,12 +731,11 @@ public function getBankAccountPaymentMethod($parameters, &$object, &$action, $ho
 			}
 		}
 
-		if (!$error) {
+		if (!$error && $bankaccountid > 0) {
 			$this->results["bankaccountid"] = $bankaccountid;
 			return 1;
 		} else {
-			$this->errors[] = $langs->trans("BankAccountNotFound");
-			return -1;
+			return 0;
 		}
 	}