Merge pull request #2 from NilesB/fix/meta-default-value

Remove default on meta field
DivineOmega · Mar 12, 2019 · f9d76c3 · f9d76c3
2 parents 12e6efe + 0e78a33
commit f9d76c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Database/Migrations/2019_02_28_094501_add_meta_to_basket_items_table.php b/src/Database/Migrations/2019_02_28_094501_add_meta_to_basket_items_table.php
@@ -2,6 +2,7 @@
 
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Schema;
 
 class AddMetaToBasketItemsTable extends Migration
@@ -13,8 +14,13 @@ class AddMetaToBasketItemsTable extends Migration
      */
     public function up()
     {
-        Schema::table('basket_items', function (Blueprint $table) {
-            $table->text('meta')->default('[]');
+        $dbType = DB::connection()->getPDO()->getAttribute(PDO::ATTR_DRIVER_NAME);
+
+        Schema::table('basket_items', function (Blueprint $table) use ($dbType) {
+            $field = $table->text('meta');
+            if ($dbType === 'sqlite') {
+                $field->default('[]');
+            }
         });
     }
 

diff --git a/src/Models/Basket.php b/src/Models/Basket.php
@@ -55,9 +55,7 @@ public function add(int $quantity, Basketable $basketable, array $meta = [])
         $item->quantity = $quantity;
         $item->basketable_type = get_class($basketable);
         $item->basketable_id = $basketable->getKey();
-        if ($meta) {
-            $item->meta = $meta;
-        }
+        $item->meta = $meta;
         $item->save();
 
         unset($this->items);