fix(cli): Log errors when adb
command fails
#3493
Open
+12
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #3436, not having
adb
in the path (or having other problems withadb
) fails silently.The problem here is that the two
adb
commands for installing and starting the app are done on a new tokio background task without logging the result. Errors are propagated to the tasks handle, but the handle is detached and therefore never checked.I wasn't sure what the best way to handle detached errors in the CLI is, so I went with simply logging errors instead of propagating them. Some open questions remain:
adb
as requirement in the docs for the mobile docs?Fixes #3436