Make the asset collection keep track of all of the destinations (#3467) #3469
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here might be more than one destination for the same asset (DioxusLabs#3467)
It might make sense to just store I opened an issue here about hot reloaded assets not getting processed: #3471 |
ealmloff
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue I mentioned in #3467, where the use of two asset! macro usages was not being treated correctly by the handler.
BEFORE you merge: Please notice that the code at: packages/cli/src/serve/handle.rs is ""wrong"" (and it was wrong before as well). It does a simple file copy without checking if it needs to be processed in any way, which is likely to lead to issues when dealing with images. I have not encountered this problem though and I don't know what purpose it serves. If you consider this to be an issue, I'd encourage you to make an issue about it.