Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: WindowCloseBehaviour #3466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: WindowCloseBehaviour #3466

wants to merge 2 commits into from

Conversation

Klemen2
Copy link
Contributor

@Klemen2 Klemen2 commented Dec 29, 2024

Closes: #3113
Fixes window not hiding for WindowCloseBehaviour:LastWindowHides,

WindowCloseBehaviour:LastWindowHides had a comment "Closing the last window will not actually close it, just hide it" but it was implemented in a way that hides all the windows so I added WindowCloseBehaviour:WindowHides that does that, and changed LastWindowHides so that it only hides on the last one, and removes the rest.

Changed multiwindow example to include tray icon & WindowCloseBehaviour:WindowHides

Temporary fix for new window not closing #3342 or at least I think that there is something else going on here and hiding the closed window is just a temporary solution to this problem since it worked in 0.5 without that.

I also changed multiwindow example to use async move, if you don't use it it gets stuck on

let webview = webview.build().unwrap();

Added WindowCloseBehaviour:WindowHides
Temporary fix for new window not closing
…con will work no matter which window you close first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowCloseBehaviour::LastWindowHides
1 participant