feat: release please setup to automate releases #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvigneshwars
added
enhancement
garryod
requested changes
Nov 29, 2024
There was a problem hiding this comment.
A few thoughts:
- How do we want to handle the helm linting which at present requires us to bump the chart version with each change - presumably this should only now be bumped by release-please?
- This will still publish containers for every tag, which we don't want
- Is there a a reason we separate the docs? And what if the
mkdocs.yamlis updated? - How do we ensure that commits are conventional? As non-conventional ones will break our usage of release-please
iamvigneshwars
force-pushed
the
release-please
branch
4 times, most recently
from
8da6d8a to
efa616f
Compare
iamvigneshwars
changed the title
garryod
requested changes
Dec 3, 2024
iamvigneshwars
force-pushed
the
release-please
branch
3 times, most recently
from
e455363 to
ea7d97c
Compare
garryod
requested changes
Dec 4, 2024
iamvigneshwars
force-pushed
the
release-please
branch
3 times, most recently
from
2f08242 to
ac5b9f0
Compare
iamvigneshwars
force-pushed
the
release-please
branch
3 times, most recently
from
ef6c299 to
b5596bd
Compare
iamvigneshwars
force-pushed
the
release-please
branch
from
b5596bd to
7b780fa
Compare
|
We should probably modify the commit messages in the dependabot to conventional commits. See here how to configure dependabot. . This issue could also be relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.