Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navbar tests, fix Jest/Babel configs #25

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Jan 10, 2025

  • Add navbar tests
  • Jest was declared as a module, but had no default export, this makes the Jest config a module. Babel has been made CommonJS, as it is the standard with this version of Babel

Next, I think I'll add workflow actions for automatically running unit tests, and possible move to Vitest!

gfrn added 5 commits January 10, 2025 11:07
Jest was declared as a module, but had no default export, this makes the Jest config a module. Babel has been made CommonJS, as it is the standard with this version of Babel
Copy link
Collaborator

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests and for the config updates.
As we've got rid of "type": "module" in package.json do we still need to change babel.config.js to babel.config.cjs?

@gfrn
Copy link
Collaborator Author

gfrn commented Jan 16, 2025

I based this off an older master branch, but I'll test it without type: module later tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants