-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CLI #401
Open
tieneupin
wants to merge
96
commits into
main
Choose a base branch
from
setup-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion is pulled by the server
… processing job IDs in the Murfey database
…on depending on other configuration operations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 27.05% 25.79% -1.26%
==========================================
Files 75 76 +1
Lines 10180 10765 +585
Branches 1343 1447 +104
==========================================
+ Hits 2754 2777 +23
- Misses 7336 7891 +555
- Partials 90 97 +7 |
…nd making keys Optional in MachineConfig
… 'get_global_config'
…t styles of config key descriptions
…ged default camera value to ''
…s received; updated 'data_directories' creation function to reflect change in MachineConfig
As of the time of this writing, the following discussed changes have been implemented:
The following changes are still needed:
|
…ory fields, but have type Optional[Path]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command line tool intended to walk non-developers through the process of setting up a configuration file in order to run Murfey properly.
Key Changes:
Security
class has been renamed toGlobalConfig
, and functions referring to it have likewise been renamed.MURFEY_GLOBAL_CONFIGURATION
environment variable instead ofMURFEY_SECURITY_CONFIGURATION
.MachineConfig
keys have been re-typed to takeOptional[Path]
instead ofstr
as part of making more parts of the Murfey workflow optional for other users. The code parsing logic has been changed to reflect this.