Nitpicky true and typing overhaul #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 99.47% 99.21% -0.26%
==========================================
Files 12 12
Lines 764 895 +131
==========================================
+ Hits 760 888 +128
- Misses 4 7 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JoshuaAppleby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitpicky = True
Add typehinting where possible, including the addition of AugmentedType and AugmentedValue, modelled off of the responses from cothread.
Doc strings have been improved in some places.
Cast typing has been used alongside appropriate comments to reduce changes to code.
Currently does not work for python 3.7 due to
SupportsIndexbeing added in 3.8. Attempts were made at importing SupportsIndex via typing_extensions, but this introduces a metaclass creation error when running CI.Additionally, cothread_cs.py does not show in the API, as otherwise cothread would have to become a dependency.