Add container build workflow

[tpoliaw]

Build the image on every PR, publish all tags

[gilesknap]

looks good. I have one suggestion inline.

If you do a beta tag on this you can check that the Publish works.

[tpoliaw]

Thanks for looking at this.

If you do a beta tag on this you can check that the Publish works.

I tried it (after changing the load/cache suggestion) and it failed because (I think) it's trying to publish to docker.io instead of ghcr.io. Any idea how to set the registry it's using? There doesn't seem to be a registry field in the options.

Also, does the image name need to be set somewhere or is it taken automatically from the repository name?

[tpoliaw]

Think I've figured it out. Things left as an exercise for later PRs

• The publish build stage doesn't seem to use any caching and downloads/compiles each time. This probably isn't a problem if it's only for releases
• The description is missing from the package registry
  • Downloading the image and running podman inspect shows that the label it's asking for is present but for some reason it's not being picked up
  • Not a big issue but it'd be good to figure out what's going on
• Setting up releases in github
  • Might be better the other way around anyway - create the tag as part of the release process
• There are additional untagged images (manifests?) being push to the registry. No idea what they are but probably don't hurt anything.

[gilesknap]

• The publish build stage doesn't seem to use any caching and downloads/compiles each time. This probably isn't a problem if it's only for releases

I would expect 'load: true' to resolve this. I certainly don't see it.

• Downloading the image and running podman inspect shows that the label it's asking for is present but for some reason it's not being picked up
• Not a big issue but it'd be good to figure out what's going on

I'm not sure which label you are discussing here

• There are additional untagged images (manifests?) being push to the registry. No idea what they are but probably don't hurt anything.

Note that if you push the same tag twice it does not delete the old image, just removes the tag from it. I'm pretty sure I also see untagged images in addition to that. I plan to create a job for our registries that cleans up untagged images occasionally.

[callumforrester]

LGTM

[tpoliaw]

I would expect 'load: true' to resolve this. I certainly don't see it.

See this one as an example. I think I was not tagging the build version correctly though so should be fixed now.

I'm not sure which label you are discussing here

On the package page here it says No description provided and

To provide a description, add the following line to your Dockerfile:
    LABEL org.opencontainers.image.description DESCRIPTION

Note that if you push the same tag twice it does not delete the old image, just removes the tag from it. I'm pretty sure I also see untagged images in addition to that. I plan to create a job for our registries that cleans up untagged images occasionally.

I don't think I've been reusing tags (other than latest) so I think they're only the additional ones. I'll ignore them for now and if you get a job working to clean them up I might borrow it.

[gilesknap]

See inline comment.

[tpoliaw]

I would expect 'load: true' to resolve this. I certainly don't see it.

I think it might just be for tags and not PRs? Epics containers appear to behave the same way, eg here the image is recompiled whereas the PR version of the same commit is using the cached version.

[tpoliaw]

Will close this as it is for now. Any other changes can be their own PR