Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from sphinx-panels to sphinx-design #488

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

yousefmoazzam
Copy link
Collaborator

@yousefmoazzam yousefmoazzam commented Oct 15, 2024

Fixes #470
Fixes #469

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@yousefmoazzam
Copy link
Collaborator Author

During local testing, the dropdown colour in dark mode had no readability issues, regardless of if the general.css file had its contents, or was empty.

Therefore, the dropdown seems to be readable in dark mode regardless of if the file is there or not, hence, it doesn't seem to be needed, which is why I have removed it.

@yousefmoazzam
Copy link
Collaborator Author

Also note that the latest docs build job indicates sphinx v8.1.3 was installed:

Running Sphinx v8.1.3

So, I think this PR fixes #469 as well.

@yousefmoazzam yousefmoazzam merged commit f619ed1 into main Oct 15, 2024
9 checks passed
@yousefmoazzam yousefmoazzam deleted the issue-470 branch October 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant