Skip to content

implement review comments

Codecov / codecov/patch succeeded Oct 15, 2024 in 1s

72.11% of diff hit (target 68.82%)

View this Pull Request on Codecov

72.11% of diff hit (target 68.82%)

Annotations

Check warning on line 70 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L70 

Added line #L70 was not covered by tests

Check warning on line 72 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L72 

Added line #L72 was not covered by tests

Check warning on line 75 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L74-L75 

Added lines #L74 - L75 were not covered by tests

Check warning on line 78 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L78 

Added line #L78 was not covered by tests

Check warning on line 91 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L91 

Added line #L91 was not covered by tests

Check warning on line 94 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L94 

Added line #L94 was not covered by tests

Check warning on line 208 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L207-L208 

Added lines #L207 - L208 were not covered by tests

Check warning on line 220 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L220 

Added line #L220 was not covered by tests

Check warning on line 224 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L223-L224 

Added lines #L223 - L224 were not covered by tests

Check warning on line 348 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L345-L348 

Added lines #L345 - L348 were not covered by tests

Check warning on line 354 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L353-L354 

Added lines #L353 - L354 were not covered by tests

Check warning on line 373 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L367-L373 

Added lines #L367 - L373 were not covered by tests

Check warning on line 389 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L389 

Added line #L389 was not covered by tests

Check warning on line 393 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L393 

Added line #L393 was not covered by tests

Check warning on line 397 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L397 

Added line #L397 was not covered by tests

Check warning on line 401 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L401 

Added line #L401 was not covered by tests
View more details on Codecov