Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bimorph mirrors #992

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open

Bimorph mirrors #992

wants to merge 128 commits into from

Conversation

dan-fernandes
Copy link
Contributor

@dan-fernandes dan-fernandes commented Jan 16, 2025

Fixes writing to bimorph when bimorph is not IDLE.

Removes unnecessary readback tolerance.

Instructions to reviewer on how to test:

  1. Check tests pass
  2. Run a bimorph mirror plan (against the simulated bimorph on BL02J or a real bimorph) and check plan behaves as expected

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (5c82bbd) to head (5d0de0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   97.52%   97.52%   -0.01%     
==========================================
  Files         154      154              
  Lines        6393     6390       -3     
==========================================
- Hits         6235     6232       -3     
  Misses        158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dodal/devices/bimorph_mirror.py Outdated Show resolved Hide resolved
tests/devices/unit_tests/test_bimorph_mirror.py Outdated Show resolved Hide resolved
tests/devices/unit_tests/test_bimorph_mirror.py Outdated Show resolved Hide resolved
@dan-fernandes
Copy link
Contributor Author

I have had an in-office conversation with Andrew Foster. We are going to write to the bimorph through setting to VOUT rather than VTRGT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants