-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bimorph mirrors #992
Open
dan-fernandes
wants to merge
128
commits into
main
Choose a base branch
from
bimorph-mirrors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bimorph mirrors #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid member name clash
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
==========================================
- Coverage 97.52% 97.52% -0.01%
==========================================
Files 154 154
Lines 6393 6390 -3
==========================================
- Hits 6235 6232 -3
Misses 158 158 ☔ View full report in Codecov by Sentry. |
callumforrester
requested changes
Jan 16, 2025
DiamondJoseph
requested changes
Jan 17, 2025
DominicOram
reviewed
Jan 24, 2025
…wo seperate calls
… functions, add docstring
4 tasks
I have had an in-office conversation with Andrew Foster. We are going to write to the bimorph through setting to |
…r commit_target_voltages
dan-fernandes
requested review from
DominicOram,
DiamondJoseph and
callumforrester
January 28, 2025 13:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes writing to bimorph when bimorph is not IDLE.
Removes unnecessary readback tolerance.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}