Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests #1000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Speed up tests #1000

wants to merge 2 commits into from

Conversation

DominicOram
Copy link
Contributor

Fixes #998

Instructions to reviewer on how to test:

  1. Run the unit tests with pytest tests/
  2. Confirm they are faster here than on main
  3. Confirm tests are still sensible

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner January 22, 2025 18:16
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (5fe0464) to head (ceedbae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1000   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         152      152           
  Lines        6351     6351           
=======================================
  Hits         6193     6193           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram requested a review from rtuck99 January 22, 2025 18:17
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sorry waiting time never crossed my mine back then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up tests
2 participants