Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up MJPG and SnapshotWithGrid structure #50

Open
DominicOram opened this issue May 11, 2023 · 2 comments
Open

Tidy up MJPG and SnapshotWithGrid structure #50

DominicOram opened this issue May 11, 2023 · 2 comments
Labels
oav question Further information is requested

Comments

@DominicOram
Copy link
Contributor

Currently SnapshotWithGrid inherits from MJPG, both of these are expected to be used in an OAV device. This is quite clean as one provides the snapshots with the grid and one without. However, because of the way Ophyd v.1 creates devices it means that it's not easy to choose at runtime which should be used without:

  • Having the OAV contain both devices
  • Having two OAV objects, one with grids and one without

We should decide if there is a better way of doing this (do it in v2?) or which of the two approaches above we prefer

@DominicOram
Copy link
Contributor Author

Would be worth discussing with @callumforrester and @coretl when we get round to implementing it

@callumforrester
Copy link
Contributor

Definitely worth discussing, am very interested in the relative pros and cons of approaches to this

@stan-dot stan-dot added question Further information is requested oav labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oav question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants