Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Tidy up OAV devices and grid plan #554

Closed
7 of 11 tasks
d-perl opened this issue Feb 28, 2023 · 1 comment · Fixed by #584
Closed
7 of 11 tasks

Tidy up OAV devices and grid plan #554

d-perl opened this issue Feb 28, 2023 · 1 comment · Fixed by #584
Assignees

Comments

@d-perl
Copy link
Contributor

d-perl commented Feb 28, 2023

Some OAV device namings are confusing, e.g.:

  • MJPG is called "snapshot"
  • inconsistent use of input_plugin_pv and input_pv (maybe areadetector plugins should be a class...)
  • chain plugins generically or at least in a consistent way
  • structure of snapshot/snapshotwithgrid etc needs cleaning
  • top_left_x_signal etc. in snapshot device classes - add clarity that this refers to grid and remove redundant "signal"
  • take arguments for grid size, margin, # of boxes (eventually to come from json)
  • deal with grid with no pin at zoom 0
  • maybe average edge detection for stability, also maybe make sure rounding is correct so grid always extends to the edge of the sample
  • add backlight manipulation
  • oav_centring_plan should be in experiment_plans rather than device_setup_plans

also:

  • look at bluesky visualisation options for live debugging
@DominicOram DominicOram moved this to Backlog in Hyperion Feb 28, 2023
@d-perl d-perl changed the title Tidy up OAV devices Tidy up OAV devices and grid plan Feb 28, 2023
@DominicOram DominicOram moved this from Backlog to Todo This Sprint in Hyperion Mar 6, 2023
@d-perl d-perl mentioned this issue Mar 16, 2023
@DominicOram DominicOram moved this from Todo This Sprint to Review in Hyperion Mar 16, 2023
@d-perl d-perl self-assigned this Mar 16, 2023
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Mar 16, 2023
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Mar 27, 2023
@DominicOram
Copy link
Collaborator

DominicOram commented May 11, 2023

To address the above that have not been addressed in the PR:

  • Tidy up MJPG and SnapshotWithGrid structure dodal#50
  • deal with grid with no pin at zoom 0 - this seems like a way off, and will probably fall out of Full centring algorithm #499
  • maybe average edge detection for stability, also maybe make sure rounding is correct so grid always extends to the edge of the sample - after tests on the beamline I think this was not much of an issue, we should get this on the beamline working and open a new issue if stability/accuracy become issues
  • look at bluesky visualisation options for live debugging - can't remember what we exactly wanted to do with this, can pick it up if it's useful later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants