Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness and liveness probes #770

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add readiness and liveness probes #770

merged 2 commits into from
Jan 10, 2025

Conversation

garryod
Copy link
Member

@garryod garryod commented Jan 9, 2025

Adds readiness and liveness probes to the backend and frontend Deployments

@garryod garryod added enhancement New feature or request helm Pull requests that update Helm Charts labels Jan 9, 2025
@garryod garryod requested a review from GDYendell January 9, 2025 16:52
@garryod garryod self-assigned this Jan 9, 2025
@garryod garryod marked this pull request as ready for review January 9, 2025 16:55
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help with failed upgrades, but does this determine readiness based on the catalog being fully populated? If not it will still result in downtime because although the readiness check will pass the dev guide won't be available. Maybe this can be improved in a future change.

@garryod
Copy link
Member Author

garryod commented Jan 10, 2025

This should help with failed upgrades, but does this determine readiness based on the catalog being fully populated? If not it will still result in downtime because although the readiness check will pass the dev guide won't be available. Maybe this can be improved in a future change.

The readiness of the backend is based on the healthcheck endpoint being available, which it won't be if it can't establish a connection to the DB

@garryod garryod merged commit 069395d into main Jan 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Pull requests that update Helm Charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants