Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dls-controls as provider #696

Conversation

stan-dot
Copy link

@stan-dot stan-dot commented May 17, 2024

next step: add catalog-info.yml to the repos

@stan-dot stan-dot requested review from gilesknap, garryod and coretl May 17, 2024 16:46
@stan-dot stan-dot linked an issue May 17, 2024 that may be closed by this pull request
2 tasks
@stan-dot stan-dot self-assigned this May 17, 2024
@coretl
Copy link

coretl commented May 23, 2024

dls-controls is going away. We need to make that happen soon

@garryod
Copy link
Member

garryod commented May 23, 2024

dls-controls is going away. We need to make that happen soon

Would you prefer we didn't add it?

@stan-dot
Copy link
Author

adding it as a source is quick, if the 'moving away from dls-controls' is even as little as week away it's no harm to migrate it now and then back. let's live in the present

@stan-dot stan-dot marked this pull request as ready for review May 30, 2024 07:40
@@ -96,6 +96,14 @@ catalog:
minutes: 60
timeout:
minutes: 10
GitHub-DLS-Controls:
organization: 'dls-controlst '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
organization: 'dls-controlst '
organization: 'dls-controls'

@garryod
Copy link
Member

garryod commented Jun 21, 2024

Closed in favour of migrating from dls-controls to DiamondLightSource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github.com/dls_controls to discovery locations and add catalog-info
3 participants