Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce Maven project #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Produce Maven project #3

wants to merge 2 commits into from

Conversation

joeshannon
Copy link
Contributor

Assemble artifacts from other workflows to generate a maven project compatible with the current structure of the hdf bundles as used in the Dawn build.

@joeshannon joeshannon requested a review from PeterC-DLS July 31, 2023 14:42
@joeshannon
Copy link
Contributor Author

joeshannon commented Jul 31, 2023

@PeterC-DLS Just wanted some initial feedback about this, particularly all the metadata in the pom.

Still todo:

  • Add info to project README
  • Copy the license files from third party code
  • Decide on versioning scheme

java-combined/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be simplified by making this an integration workflow that calls the other build workflows where they set a common name for their uploads. Then can also ensure all builds succeed.

@joeshannon
Copy link
Contributor Author

I think this could be simplified by making this an integration workflow that calls the other build workflows where they set a common name for their uploads. Then can also ensure all builds succeed.

Yes that sounds like it would definitely be nicer. The current downloading is just looking for the last successful build which is not very robust and could lead to major inconsistencies.

Do you know how to do this/have any examples?

@PeterC-DLS
Copy link
Contributor

@joeshannon joeshannon force-pushed the combine-workflow branch 12 times, most recently from 4a54f21 to 6e9cca9 Compare July 31, 2023 17:59
@joeshannon
Copy link
Contributor Author

For reference, the only thing I've found related to the win32 tar failure is https://cygwin.com/pipermail/cygwin/2023-May/253738.html

@joeshannon joeshannon force-pushed the combine-workflow branch 5 times, most recently from 615df85 to 217ecb0 Compare August 1, 2023 12:24
@@ -72,7 +72,9 @@ download_check_extract_pushd() {
exit 1
fi
fi
set +e # Allow this to exit with non-zero for win32 strangeness
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put in this slightly horrible workaround for now.
I had a look at a newer windows image as suggested but it seemed to be missing a lot of build dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants