-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce Maven project #3
base: main
Are you sure you want to change the base?
Conversation
@PeterC-DLS Just wanted some initial feedback about this, particularly all the metadata in the pom. Still todo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be simplified by making this an integration workflow that calls the other build workflows where they set a common name for their uploads. Then can also ensure all builds succeed.
Yes that sounds like it would definitely be nicer. The current downloading is just looking for the last successful build which is not very robust and could lead to major inconsistencies. Do you know how to do this/have any examples? |
Reusable workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows |
4a54f21
to
6e9cca9
Compare
For reference, the only thing I've found related to the win32 tar failure is https://cygwin.com/pipermail/cygwin/2023-May/253738.html |
615df85
to
217ecb0
Compare
@@ -72,7 +72,9 @@ download_check_extract_pushd() { | |||
exit 1 | |||
fi | |||
fi | |||
set +e # Allow this to exit with non-zero for win32 strangeness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put in this slightly horrible workaround for now.
I had a look at a newer windows image as suggested but it seemed to be missing a lot of build dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will do, thanks!
217ecb0
to
907c94e
Compare
907c94e
to
2d86845
Compare
2d86845
to
9a3ac21
Compare
9a3ac21
to
3fd3a60
Compare
Assemble artifacts from other workflows to generate a maven project compatible with the current structure of the hdf bundles as used in the Dawn build.