LIMS-1563 - Remove touchscreen app #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfrn
added
javascript
gfrn
changed the title
ndg63276
reviewed
Dec 2, 2024
ndg63276
approved these changes
Dec 2, 2024
Co-authored-by: Mark W <[email protected]>
ndg63276
added a commit
that referenced
this pull request
Jan 10, 2025
* LIMS-1569: Get image viewer rings from dials if possible (#875) * LIMS-1002: Fix error when creating new laboratory (#815) * LIMS-1302 - add visit to container even if UAS fails (#762) * LIMS-1487: Fix alphafold triggering (#866) * LIMS-1563 - Remove touchscreen app (#867) Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1563
Summary:
To improve security, reduce code size, and ameliorate the repository readability, the touchscreen beamline sample definition page was removed. This page was not in use (given it had been superseded by an internal application), did not work as intended, and was confirmed not to be at use by any beamline.
Changes:
To test:
/touchscreen, ensure 404 is returned/visits/{some-visit-id}ensure 404 is returned