Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-980: Add all samples to queue should obey filters #707

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jan 3, 2024

JIRA ticket: LIMS-980

Summary:

LIMS-219 (#591) added a button to add all subsamples to the queue, but it ignored the current filter, which can be auto/manual/point/region.

Changes:

  • Get the id of the currently selected filter element and add it to the backend request
  • Use the filter supplied to alter the where clause of the query

To test:

  • Go to a VMXi proposal (eg nt37104), go to Containers, pick one. On the next page mark a point and a region using the "Mark Point" and "Mark Region" buttons. Click "Prepare for Data Collection"
  • Filter the available samples using the Point/Region/Auto/Manual buttons, click the Add All to Queue button. Check the right number appear in the queue in the lower half of the page.
  • Turn off any filters and Add All again, check every (not complete) sample is added to the queue.

Co-authored-by: Guilherme Francisco <[email protected]>
@ndg63276 ndg63276 requested a review from gfrn January 19, 2024 11:49
Copy link
Collaborator

@gfrn gfrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this depends on LIMS-979, but looks good to me!

@ndg63276 ndg63276 merged commit 28a021b into prerelease Jan 19, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-980/add-all-samples-should-obey-filters branch January 19, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants