Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft Active Directory in LDAP authentication #346

Conversation

stuartcampbell
Copy link
Contributor

The current schema / format of the dn that works with OpenLDAP servers does not always work when trying to use an Active Directory domain controller as an LDAP authentication server.

In testing it seems more reliable to authentication using a username of DOMAIN\\username rather than trying to guess what the dn is being used at a given site. The problem is that the username is not always part of the dn for AD, but using the username and domain name always seems to work.

I've tested the code in this PR at BNL using the onsite Active Directory Domain Controllers (and also using a DUO MFA proxy server). I have not tested against Azure AD.

@ndg63276 ndg63276 requested a review from NKatti2011 November 14, 2023 14:52
@NKatti2011
Copy link
Collaborator

Looks good to me

@NKatti2011 NKatti2011 merged commit ac5f9d8 into DiamondLightSource:prerelease Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants