Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPConnection #18

Closed
wants to merge 1 commit into from
Closed

Add HTTPConnection #18

wants to merge 1 commit into from

Conversation

GDYendell
Copy link
Contributor

No description provided.

@GDYendell GDYendell requested a review from MJGaughran November 28, 2023 16:27
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (497316c) 45.19% compared to head (44d3d90) 45.15%.

Files Patch % Lines
src/fastcs/connections.py 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   45.19%   45.15%   -0.04%     
==========================================
  Files          17       17              
  Lines         624      640      +16     
==========================================
+ Hits          282      289       +7     
- Misses        342      351       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell
Copy link
Contributor Author

It has become clear that needs to be eiger-specific. It could possibly be refactored into a shared base class when we have a second use case.

@GDYendell GDYendell closed this Jan 16, 2024
@GDYendell GDYendell deleted the HTTP branch June 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants