Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to --version for controller CLI #114

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Change to --version for controller CLI #114

merged 1 commit into from
Jan 27, 2025

Conversation

marcelldls
Copy link
Contributor

The reason to propose this change is because it is more consistent with the existing DLS python template project which reduces conflicts that need to be resolved

@marcelldls marcelldls requested a review from GDYendell January 24, 2025 16:59
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (2f91987) to head (cde6ee4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          31       31           
  Lines        1341     1342    +1     
=======================================
+ Hits         1177     1178    +1     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell GDYendell merged commit 57316cd into main Jan 27, 2025
17 checks passed
@GDYendell GDYendell deleted the dash-dash-version branch January 27, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants