Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge code mark 1 #3

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Merge code mark 1 #3

merged 4 commits into from
Mar 8, 2024

Conversation

Devasy23
Copy link
Owner

@Devasy23 Devasy23 commented Mar 8, 2024

Description

This pull request introduces the ability to handle multiple images for each employee in our face recognition system. This includes changes to the create_new_faceEntry function to process multiple images, as well as updates to our test suite to cover these new functionalities.

Changes

  • Updated create_new_faceEntry function to handle multiple images for each employee.
  • Modified the Employee and UpdateEmployee models to include a list of images instead of a single image.
  • Updated test_face_lifecycle function to handle multiple images for each employee in the test data.
  • Adjusted the mock data and assertions in test_face_cycle.py to handle multiple images for each employee.

Fixes

  • Resolved an issue where the create_new_faceEntry function was not correctly processing multiple images for each employee.

Testing

All tests pass with the new changes. Test coverage remains at 100%.

Please review and let me know if you have any questions or feedback.

@Devasy23 Devasy23 added enhancement New feature or request good first issue Good for newcomers labels Mar 8, 2024
@Devasy23 Devasy23 requested a review from devansh-shah-11 March 8, 2024 11:47
@Devasy23 Devasy23 self-assigned this Mar 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.03922% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.40%. Comparing base (47cc66b) to head (be9f403).
Report is 2 commits behind head on main.

Files Patch % Lines
API/route.py 95.65% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   66.66%   70.40%   +3.73%     
==========================================
  Files           6        7       +1     
  Lines         216      250      +34     
==========================================
+ Hits          144      176      +32     
- Misses         72       74       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

API/route.py Dismissed Show dismissed Hide dismissed
@devansh-shah-11
Copy link
Collaborator

Hey @Devasy23 ,

The code is functioning pretty well.

  1. However, the update function needs to have the embeddings stored.
  2. Also, it would be great if logging statements are written in the API endpoints to ensure easy debugging

@devansh-shah-11 devansh-shah-11 merged commit c465bcc into main Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants