Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks for preview build #1179

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Some tweaks for preview build #1179

merged 2 commits into from
Jun 2, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 2, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 only has a stable icon. There's no preview icon yet.

What is the new behavior?

By default, when building locally, DevToys has a "preview" icon.
The icon & splash screen is switched to "stable" or "preview" during publication. See https://github.com/DevToys-app/Publish/pull/3

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux June 2, 2024 00:52
@veler veler merged commit 176d5f6 into main Jun 2, 2024
2 of 3 checks passed
@veler veler deleted the updated-preview branch June 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants