Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logout routes and remember me #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AshGDS
Copy link

@AshGDS AshGDS commented Sep 5, 2019

Hi,

Thank you for your Multi Auth tutorials, they are very helpful. I have noticed a bug though - if you tick Remember Me when logging in, logging out does not work. This is because the logout functions we created in Part 4 are never being accessed. Currently, clicking logout takes you to Laravel's default /logout page instead of /users/logout and /admin/logout.

To fix this, I have:

  • Created a helpers.php file which contains two functions that can run in our blade file. One hides the logout dialogue from the admin login page, and the other returns the correct logout route.
  • Changed the logout routes to POST, as that is what Laravel is expecting.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant