-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented allowedUntypedLibraries config #970
Merged
DetachHead
merged 9 commits into
DetachHead:main
from
Wizzerinus:feature/config/allowed-untyped-libraries
Jan 14, 2025
Merged
Implemented allowedUntypedLibraries config #970
DetachHead
merged 9 commits into
DetachHead:main
from
Wizzerinus:feature/config/allowed-untyped-libraries
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DetachHead
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are probably other things we will need to consider as well that haven't yet crossed my mind
DetachHead
reviewed
Jan 7, 2025
This comment has been minimized.
This comment has been minimized.
Wizzerinus
force-pushed
the
feature/config/allowed-untyped-libraries
branch
from
January 9, 2025 15:50
5b2c8f3
to
665bc94
Compare
Wizzerinus
force-pushed
the
feature/config/allowed-untyped-libraries
branch
from
January 9, 2025 15:53
665bc94
to
e302c06
Compare
DetachHead
reviewed
Jan 9, 2025
This comment has been minimized.
This comment has been minimized.
…clusive settings" section of "Environment Options"
DetachHead
approved these changes
Jan 11, 2025
beauxq
reviewed
Jan 11, 2025
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- Type of "i" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "i" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | Unknown | list[Min | Max] | list[Expr | Unknown] | list[Unknown | Poly])" (reportUnknownVariableType)
+ Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | Unknown | list[Min | Max] | list[Unknown] | list[Unknown | Poly])" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_decompogen.py:23:31 - warning: Return type of lambda, "list[Expr] | list[Function | Pow] | Unknown | list[Min | Max] | list[Expr | Unknown] | list[Unknown | Poly]", is partially unknown (reportUnknownLambdaType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_decompogen.py:23:31 - warning: Return type of lambda, "list[Expr] | list[Function | Pow] | Unknown | list[Min | Max] | list[Unknown] | list[Unknown | Poly]", is partially unknown (reportUnknownLambdaType)
- Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr)" (reportUnknownVariableType)
+ Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr)" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:134:9 - warning: Type of "inf" is partially unknown
- Type of "inf" is "One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Unknown" (reportUnknownVariableType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Type of "e" is "Equality | Unknown | Relational | Unequality | NaN | Sum" (reportUnknownVariableType)
+ Type of "e" is "Equality | Unknown | NaN | Sum" (reportUnknownVariableType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr" (reportUnknownVariableType)
+ Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr" (reportUnknownVariableType)
- Type of "ie" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "ie" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "e" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "e" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "wave" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "wave" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "sol4" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "sol4" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality)" (reportUnknownMemberType)
+ Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown" (reportUnknownMemberType)
- Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality)" (reportUnknownMemberType)
+ Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_recurr.py:116:5 - warning: Type of "h" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_recurr.py:116:5 - warning: Type of "h" is Any (reportAny)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:104:9 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality], Any]", is partially unknown (reportUnknownParameterType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:104:9 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool], Any]", is partially unknown (reportUnknownParameterType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:105:13 - warning: Return type, "Integer | Unknown | NaN | Expr | One | NegativeOne | Zero | Rational | ComplexInfinity | Half", is partially unknown (reportUnknownParameterType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:109:20 - warning: Return type, "Unknown | NaN | Expr | One | NegativeOne | Zero | Integer | Rational | ComplexInfinity | Half", is partially unknown (reportUnknownVariableType)
- Type of "constraints" is "list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality]" (reportUnknownVariableType)
+ Type of "constraints" is "list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:111:29 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "sum"
- Argument type is "Generator[Any | Unknown, None, None]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:113:25 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "sum"
- Argument type is "Generator[Any | Unknown, None, None]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:114:16 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality], Any]", is partially unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:114:16 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool], Any]", is partially unknown (reportUnknownVariableType)
- Type of "r1" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "r1" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "r2" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "r2" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "constraints" is "list[Equality | Unknown | Relational | Unequality | Any]" (reportUnknownVariableType)
+ Type of "constraints" is "list[Equality | Unknown | Any]" (reportUnknownVariableType)
- Type of "constr" is "Equality | Unknown | Relational | Unequality | Any" (reportUnknownVariableType)
+ Type of "constr" is "Equality | Unknown | Any" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:181:5 - warning: Type of "ans" is partially unknown
- Type of "ans" is "tuple[Unknown, list[int | Unknown]]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:221:9 - warning: Type of "ans" is partially unknown
- Type of "ans" is "tuple[Unknown, list[int | Unknown]]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:222:48 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "__init__"
- Argument type is "zip[tuple[Any, int | Unknown]]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:222:55 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iter2" in function "__new__"
... (truncated 2673 lines) ...
dulwich (https://github.com/dulwich/dulwich): 2.92x slower (6.0s -> 17.6s in a single noisy sample)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this PR adds an
allowedUntypedLibraries
config field which is a list of strings (empty by default). If pyright cannot derive the type of a function, it normally gives an error (reportUnknownMemberType
orreportUnknownVariableType
), and if the library the method is implemented in is in this list, it doesn't, for example:Notes:
allowedUntypedModules
instead of librarieslibrary
is strongly typed butlibrary.new_submodule
isn't"), although I think this is not necessary due to the uses of this feature (the point is that the rule normally targets the code written for the project, and this PR targets the code written for a library used in the project, which are usually not intersecting)resolves #701