Add default pythonPath #1006

cpprust · 2025-01-20T13:24:37Z

fixes: #365
Use expected venv python path as default pythonPath

If user not set venv, venvPath and pythonPath,
It will try to set pythonPath to
".venv/bin/python" or ".venv/Scripts/python.exe".

However I didn't build and test on Windows.

If user not set venv, venvPath and pythonPath, It will try to set pythonPath to ".venv/bin/python" or ".venv/Scripts/python.exe". However I didn't build and test on Windows.

DetachHead · 2025-01-20T23:13:20Z

thanks! i will test this on windows later today

DetachHead · 2025-01-21T14:11:16Z

just pushed some changes and updated the docs. thanks again for the contribution

…Path` is sufficient

cpprust · 2025-01-21T16:51:33Z

Thank you for saving my butt, I didn't even notice that my logic is completely wrong.

cpprust · 2025-01-21T16:52:01Z

Sorry i hit the wrong button...

packages/pyright-internal/src/analyzer/service.ts

github-actions · 2025-01-21T22:57:17Z

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-     Type of "sol1" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+     Type of "sol1" is "Equality | Unknown" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:37:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:38:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:39:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:40:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:41:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:42:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/tests/test_subscheck.py:43:34 - error: Cannot access attribute "lhs" for class "Integer"
-     Attribute "lhs" is unknown (reportAttributeAccessIssue)
-     Type of "sol3" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+     Type of "sol3" is "Equality | Unknown" (reportUnknownVariableType)
-     Type of "eqn" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+     Type of "eqn" is "Equality | Unknown" (reportUnknownVariableType)
-     Type of "sol" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+     Type of "sol" is "Equality | Unknown" (reportUnknownVariableType)
-     Type of "sol" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+     Type of "sol" is "Equality | Unknown" (reportUnknownVariableType)
-     Type of "eqs" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eqs" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)
-     Type of "eq" is "tuple[Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer, Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "eq" is "tuple[Equality | Unknown, Equality | Unknown, Equality | Unknown]" (reportUnknownVariableType)
-     Type of "sol" is "list[Equality | Unknown | Relational | Unequality | Integer]" (reportUnknownVariableType)
+     Type of "sol" is "list[Equality | Unknown]" (reportUnknownVariableType)

... (truncated 3441 lines) ...

arviz (https://github.com/arviz-devs/arviz): 3.23x slower (9.1s -> 29.4s in a single noisy sample)

cpprust added 2 commits January 20, 2025 21:09

Use expected venv python path as default pythonPath

726f977

If user not set venv, venvPath and pythonPath, It will try to set pythonPath to ".venv/bin/python" or ".venv/Scripts/python.exe". However I didn't build and test on Windows.

Apply npm prettier

6b57210

This comment has been minimized.

Sign in to view

Change let to const

d71c41c

This comment has been minimized.

Sign in to view

DetachHead added 2 commits January 21, 2025 22:32

fix if statement for default pythonPath

de29407

check if windows before checking the default venv for pythonPath

821a2f6

DetachHead approved these changes Jan 21, 2025

View reviewed changes

DetachHead added 3 commits January 22, 2025 00:36

update documentation with info about default pythonPath

37ccdfd

remove windows/unix specific npm scripts now that the default `python…

b822333

…Path` is sufficient

add npm script to run the language server

b5f865e

DetachHead force-pushed the add-default-python-path branch from af7eca5 to b5f865e Compare January 21, 2025 14:36

This comment has been minimized.

Sign in to view

cpprust closed this Jan 21, 2025

cpprust reopened this Jan 21, 2025

DetachHead reviewed Jan 21, 2025

View reviewed changes

packages/pyright-internal/src/analyzer/service.ts Outdated Show resolved Hide resolved

fix typo in comment

bf74a81

DetachHead enabled auto-merge (rebase) January 21, 2025 23:11

DetachHead disabled auto-merge January 21, 2025 23:11

DetachHead merged commit 3bb4dd2 into DetachHead:main Jan 21, 2025
16 checks passed

This was referenced Jan 24, 2025

improve documentation for venv and venvPath #1002

Closed

Change default to use ".venv" under project root #1001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add default pythonPath #1006

Add default pythonPath #1006

cpprust commented Jan 20, 2025

DetachHead commented Jan 20, 2025

This comment has been minimized.

This comment has been minimized.

DetachHead commented Jan 21, 2025

This comment has been minimized.

cpprust commented Jan 21, 2025

cpprust commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

Add default pythonPath #1006

Add default pythonPath #1006

Conversation

cpprust commented Jan 20, 2025

DetachHead commented Jan 20, 2025

This comment has been minimized.

This comment has been minimized.

DetachHead commented Jan 21, 2025

This comment has been minimized.

cpprust commented Jan 21, 2025

cpprust commented Jan 21, 2025

github-actions bot commented Jan 21, 2025